Skip to content

fix: resolve critical export, preview, trim and memory bugs#945

Open
Vedhant26 wants to merge 2 commits into
magic-peach:mainfrom
Vedhant26:fix/issue-930-critical-bugs
Open

fix: resolve critical export, preview, trim and memory bugs#945
Vedhant26 wants to merge 2 commits into
magic-peach:mainfrom
Vedhant26:fix/issue-930-critical-bugs

Conversation

@Vedhant26
Copy link
Copy Markdown
Contributor

@Vedhant26 Vedhant26 commented May 22, 2026

Hey folks! 👋 I've taken a deep dive into the critical bugs reported in #930 and put together this PR which resolves all four of the major issues affecting the editing pipeline.

Here's exactly what I've fixed:

  1. Export Size Estimation (Preset ID Mismatch): I've removed the hardcoded \PRESET_DIMENSIONS\ object which was out of sync with the actual IDs. The app now directly uses \getPresetById\ to ensure export sizes are predicted accurately for vertical and portrait formats.
  2. Preview Crop Geometry: I swapped the inverted logic for the \ ill\ crop mode. When the output is taller (e.g. 9:16), it correctly indicates left/right cropping, giving accurate visual feedback!
  3. Trim State Leak (NaNs): I created a dedicated \endInput\ state in the \TrimControl\ component. It now waits until all validations pass before firing \onChange, completely preventing invalid states (like \NaN) from bleeding into the global calculations.
  4. Thumbnail Strip Memory Usage (OOM fix): I dynamically capped the thumbnail generation interval based on the total video duration. This prevents the browser from generating hundreds of canvases and freezing on long videos.

I've tested these out locally and everything is super smooth and stable now. Let me know if there's anything else you need changed. Cheers! 🚀

Closes #930

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Vedhant26 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

👋 Thanks for your PR, @Vedhant26!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

✅ PR Format Check Passed — @Vedhant26

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix labels May 22, 2026
@Vedhant26
Copy link
Copy Markdown
Contributor Author

Vedhant26 commented May 22, 2026

Issues resolved ! Ready to merge !

@magic-peach magic-peach added gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts and removed level:intermediate Intermediate level - 35 pts labels May 24, 2026
@magic-peach magic-peach mentioned this pull request May 24, 2026
Open
13 tasks
@magic-peach
Copy link
Copy Markdown
Owner

magic-peach commented May 24, 2026

@Vedhant26 Excellent work on these critical bug fixes! All four fixes are well-targeted and the code quality is high:

  1. Export size estimation — using getPresetById instead of the stale hardcoded map is the right fix
  2. Preview crop geometry — the inverted logic fix is correct
  3. Trim state leak — the endInput local state approach prevents NaN from propagating
  4. Thumbnail OOM fix — dynamically capping the interval is a clean solution

However, this PR has merge conflicts with main and build/lint/typecheck CI hasn't run yet.

Steps to fix:

git fetch upstream
git rebase upstream/main
# Resolve conflicts in TrimControl.tsx, VideoPreview.tsx, ThumbnailStrip.tsx
git push --force-with-lease origin fix/issue-930-critical-bugs

Also note: PR #907 fixes the same endInput bug in TrimControl.tsx. If that gets merged first, you'll need to adjust your TrimControl changes to avoid conflicts.

Once rebased and CI passes, this will be merged promptly!

@github-actions github-actions Bot added the level:intermediate Intermediate level - 35 pts label May 24, 2026
@Vedhant26 Vedhant26 force-pushed the fix/issue-930-critical-bugs branch from f59237e to 33242ac Compare May 24, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts level:intermediate Intermediate level - 35 pts type:bug Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Multiple Critical Bugs Affecting Export Accuracy, Preview Geometry, Trim Stability, and Large Video Performance

2 participants

@Vedhant26 @magic-peach